fix(ci): inherit secrets into the release workflow, serialize tag-on-main - #100
Open
thetillhoff wants to merge 1 commit into
Open
fix(ci): inherit secrets into the release workflow, serialize tag-on-main#100thetillhoff wants to merge 1 commit into
thetillhoff wants to merge 1 commit into
Conversation
…main The v3.0.5 release succeeded but its run went red: the homebrew tap step got an empty GH_TOKEN, because a called workflow receives no secrets unless the caller passes them. Third instance of the workflow_call path behaving differently from `on: push: tags:`. Also adds a concurrency group. Two merges in quick succession would run in parallel, both read the same `git describe` tag and compute the same next version - one tag push wins, the other fails. Not cancel-in-progress: a cancelled run leaves a tag whose release never happened. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
thetillhoff
enabled auto-merge
July 31, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3.0.5 published correctly but the run is red:
secrets.HOMEBREW_TAP_ACCESS_TOKENresolved to empty: a called workflow receives no secrets unless the caller passes them. So on the automated path the homebrew tap is never updated - third instance of the same class as #99, where theworkflow_callentry point behaves differently fromon: push: tags:.secrets: inheritfixes it.Second change, a race nobody has hit yet:
tag-on-mainhad noconcurrencygroup. Two renovate merges close together run in parallel, both read the samegit describeoutput, and compute the same next version - one tag push wins, the other fails. Today's merges were 2-8 minutes apart, which is luck, not design. Now serialized withcancel-in-progress: false, because cancelling mid-run is how you get a tag whose release never happened.Same fixes go to webscan.